linux-kernel - Re: [PATCH v2] spi: atmel: cleanup wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Feb 2015 11:26:12 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>, linux-spi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] spi: atmel: cleanup wait_for_completion return
 handling

On Mon, Feb 02, 2015 at 10:43:31AM -0500, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch adds an appropriate variable and fixes up the assignment. It removes 
> the else branch as the only thing it was doing is assigning ret = 0; - but 
> ret is never used thereafter so that is not needed. As the string in 
> dev_err already states "timeout" there is little point in printing the 0. 
> A typo in "trasfer" -> transfer is also fixed.

Applied, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)