lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 4 Feb 2015 11:54:39 +0000
From:	David Laight <David.Laight@...LAB.COM>
To:	'David Gibson' <david@...son.dropbear.id.au>,
	"benh@...nel.crashing.org" <benh@...nel.crashing.org>,
	"mpe@...erman.id.au" <mpe@...erman.id.au>,
	"paulus@...ba.org" <paulus@...ba.org>,
	"agraf@...e.de" <agraf@...e.de>
CC:	"aik@...abs.ru" <aik@...abs.ru>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"mdroth@...ibm.com" <mdroth@...ibm.com>
Subject: RE: [PATCH 0/5] powerpc: Get rid of redundant arch specific swab
 functions

From: David Gibson
> arch/powerpc/include/asm/swab.h includes some powerpc specific
> byteswapping functions, which are implemented in terms of powerpc's
> built in byte reversed load/store instructions.  There are two problems with this:
> 
> 1) They're not necessary - gcc is perfectly capable of generating the
>    byte-reversed load and store instructions when using the normal,
>    generic byteswapping functions (tested with gcc (GCC) 4.8.3
>    20140911 (Red Hat 4.8.3-9))

Should you be worrying about older versions of gcc?
IIRC the internal byteswap 'stuff' is relatively recent (like
the last couple of years) so people building current kernels
on older distributions might have issues.

	David

Powered by blists - more mailing lists