linux-kernel - Re: [PATCH 4/5] powerpc: Cleanup KVM emulated load/store endian handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D22D10.2040502@suse.de>
Date:	Wed, 04 Feb 2015 15:30:40 +0100
From:	Alexander Graf <agraf@...e.de>
To:	David Gibson <david@...son.dropbear.id.au>,
	benh@...nel.crashing.org, mpe@...erman.id.au, paulus@...ba.org
CC:	aik@...abs.ru, mdroth@...ibm.com, linuxppc-dev@...ts.ozlabs.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] powerpc: Cleanup KVM emulated load/store endian handling



On 03.02.15 06:36, David Gibson wrote:
> Sometimes the KVM code on powerpc needs to emulate load or store
> instructions from the guest, which can include both normal and byte
> reversed forms.
> 
> We currently (AFAICT) handle this correctly, but some variable names are
> very misleading.  In particular we use "is_bigendian" in several places to
> actually mean "is the IO the same endian as the host", but we now support
> little-endian powerpc hosts.  This also ties into the misleadingly named
> ld_le*() and st_le*() functions, which in fact always byteswap, even on
> an LE host.
> 
> This patch cleans this up by renaming to more accurate "host_swabbed", and
> uses the generic swab*() functions instead of the powerpc specific and
> misleadingly named ld_le*() and st_le*() functions.
> 
> Signed-off-by: David Gibson <david@...son.dropbear.id.au>

Reviewed-by: Alexander Graf <agraf@...e.de>


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/