linux-kernel - Re: [PATCH 1/3] iio: vf610_adc: cleanup wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D25061.4030909@kernel.org>
Date:	Wed, 04 Feb 2015 17:01:21 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Nicholas Mc Guire <hofrat@...dl.org>
CC:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	Fugang Duan <B38611@...escale.com>,
	Sanjeev Sharma <sanjeev_sharma@...tor.com>,
	Sanchayan Maity <maitysanchayan@...il.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] iio: vf610_adc: cleanup wait_for_completion return
 handling

On 02/02/15 08:35, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch only fixes up the return handling.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@...dl.org>
Applied to the togreg branch of iio.git which will at somepoint get
pushed out as testing for the autobuilders to play with. 
If anyone has comments still plenty of time before I push this out
properly!

J
> ---
>  drivers/iio/adc/vf610_adc.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Rather than changing timeout to unsigned long it can be moved into the
> if condition and dropped.
> 
> Patch was compile tested only for imx_v6_v7_defconfig + CONFIG_IIO=m,
> CONFIG_VF610_ADC=m
> 
> Patch is against 3.19.0-rc6 -next-20150130
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 8ec353c..5b72d17 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -259,7 +259,6 @@ static void vf610_adc_cfg_post_set(struct vf610_adc *info)
>  static void vf610_adc_calibration(struct vf610_adc *info)
>  {
>  	int adc_gc, hc_cfg;
> -	int timeout;
>  
>  	if (!info->adc_feature.calibration)
>  		return;
> @@ -271,9 +270,7 @@ static void vf610_adc_calibration(struct vf610_adc *info)
>  	adc_gc = readl(info->regs + VF610_REG_ADC_GC);
>  	writel(adc_gc | VF610_ADC_CAL, info->regs + VF610_REG_ADC_GC);
>  
> -	timeout = wait_for_completion_timeout
> -			(&info->completion, VF610_ADC_TIMEOUT);
> -	if (timeout == 0)
> +	if (!wait_for_completion_timeout(&info->completion, VF610_ADC_TIMEOUT))
>  		dev_err(info->dev, "Timeout for adc calibration\n");
>  
>  	adc_gc = readl(info->regs + VF610_REG_ADC_GS);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/