linux-kernel - Re: [PATCH] tty/sysrq: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Feb 2015 18:56:08 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.cz>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Subject: Re: [PATCH] tty/sysrq: fix sparse warnings

On Wed, Feb 4, 2015 at 6:27 PM, Lad Prabhakar
<prabhakar.csengg@...il.com> wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
>
> this patch fixes following sparse warnings:
> sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static?
> sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static?
>
Sorry for the nose please drop this patch, it causes build failure,

drivers/tty/sysrq.c:58:23: error: weak declaration of
‘platform_sysrq_reset_seq’ must be public
 static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
                       ^
drivers/tty/sysrq.c:59:12: error: weak declaration of
‘sysrq_reset_downtime_ms’ must be public
 static int sysrq_reset_downtime_ms __weak;
            ^
Cheers,
--Prabhakar Lad

> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  Found this issue on linux-next (gcc  version 4.8.2,
>  sparse version  0.4.5-rc1)and applies on top linux-next.
>
>  drivers/tty/sysrq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c
> index 259a4d5..d272a37 100644
> --- a/drivers/tty/sysrq.c
> +++ b/drivers/tty/sysrq.c
> @@ -55,8 +55,8 @@
>  static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE;
>  static bool __read_mostly sysrq_always_enabled;
>
> -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> -int sysrq_reset_downtime_ms __weak;
> +static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED };
> +static int sysrq_reset_downtime_ms __weak;
>
>  static bool sysrq_on(void)
>  {
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/