linux-kernel - Re: [PATCH] MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150204190018.GA7818@dtor-ws>
Date:	Wed, 4 Feb 2015 11:00:18 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andrey Ryabinin <a.ryabinin@...sung.com>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>, linux-parisc@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MODULE_DEVICE_TABLE: fix gscps2

On Wed, Feb 04, 2015 at 04:15:35PM +0100, Geert Uytterhoeven wrote:
> The patch "module: fix types of device tables aliases" newly requires
> that invocations of
> 
> MODULE_DEVICE_TABLE(type, name);
> 
> come *after* the definition of `name'.  That is reasonable, but gscps2
> wasn't doing this.  Fix it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied, thank you.

> ---
> One more fix for your collection...
> 
> parisc/allmodconfig
> http://kisskb.ellerman.id.au/kisskb/buildresult/12358386/
> ---
>  drivers/input/serio/gscps2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/gscps2.c b/drivers/input/serio/gscps2.c
> index 8d9ba0c3827c5b2a..94ab494a6ade8d49 100644
> --- a/drivers/input/serio/gscps2.c
> +++ b/drivers/input/serio/gscps2.c
> @@ -40,7 +40,6 @@
>  MODULE_AUTHOR("Laurent Canet <canetl@...ee.fr>, Thibaut Varene <varenet@...isc-linux.org>, Helge Deller <deller@....de>");
>  MODULE_DESCRIPTION("HP GSC PS2 port driver");
>  MODULE_LICENSE("GPL");
> -MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
>  
>  #define PFX "gscps2.c: "
>  
> @@ -439,6 +438,7 @@ static struct parisc_device_id gscps2_device_tbl[] = {
>  #endif
>  	{ 0, }	/* 0 terminated list */
>  };
> +MODULE_DEVICE_TABLE(parisc, gscps2_device_tbl);
>  
>  static struct parisc_driver parisc_ps2_driver = {
>  	.name		= "gsc_ps2",
> -- 
> 1.9.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/