linux-kernel - Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D299D6.7060809@cogentembedded.com>
Date:	Thu, 05 Feb 2015 01:14:46 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Mike Turquette <mturquette@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Geert Uytterhoeven <geert+renesas@...der.be>
CC:	Stephen Boyd <sboyd@...eaurora.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Ulrich Hecht <ulrich.hecht+renesas@...il.com>,
	Wolfram Sang <wsa@...g-engineering.com>,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

Hello.

On 02/05/2015 01:04 AM, Sergei Shtylyov wrote:

>>>>> Anyone may call clk_round_rate() with a zero rate value, so we have to
>>>>> protect against that.

>>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

>>>> Acked-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

>>>> I agree that this should not be fixed in the core because the fixup is
>>>> really driver dependant.

>>>      Dunno, zero frequency seems generally insane to me.

>> It is useful to find the lowest frequency a clock can support. Basically
>> it is a search for the floor frequency.

>     Why not just use 1? Or are you assuming that some hardware could actually
> support 0 Hz?

    Replying to myself: yes, this has happened to me, when I forgot to 
override the EXTAL frequency in the board .dts file (default was 0).

>> Regards,
>> Mike

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/