linux-kernel - Re: [PATCH V4 2/2] bfin_can: rewrite the driver into common style with MMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D32ECC.7070809@pengutronix.de>
Date:	Thu, 05 Feb 2015 09:50:20 +0100
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	Aaron Wu <Aaron.wu@...log.com>, wg@...ndegger.com,
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-devel@...log.com
Subject: Re: [PATCH V4 2/2] bfin_can: rewrite the driver into common style
 with MMU

On 02/05/2015 09:28 AM, Aaron Wu wrote:
> Rewrite the blackfin CAN driver into common style
> V4 changes: remove unused variable in patch 2/2
> V3 changes: remove redundant cast in patch 2/2
> V2 changes: split patch into two parts
> V1 changes: rewrite code into common style
> 
> Signed-off-by: Aaron Wu <Aaron.wu@...log.com>

The code looks good, the patch description can be improved though.
Please replace the change history by a description what this patch does
and why. For this kind of patch a single sentence would be enough, but
rewrite into common style is to generic. (Same applies to 1/2)

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)