linux-kernel - Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205125124.GG5336@mwanda>
Date:	Thu, 5 Feb 2015 15:51:24 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	devel@...verdev.osuosl.org,
	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Chaitanya Hazarey <c@...io>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	linux-kernel@...r.kernel.org, Greg Donald <gdonald@...il.com>,
	Koray Gulcu <koray.gulcu@....edu.tr>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null
 pointer dereference

On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
> if (driver_info) {
> 	stats->RxIs40MHzPacket = driver_info->BW;
> 	if (stats->RxDrvInfoSize != 0)
> 		TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
> }

If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and
also the reverse.  So really you only need to test one.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/