| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 05 Feb 2015 15:20:27 +0100 From: SF Markus Elfring <elfring@...rs.sourceforge.net> To: Dan Carpenter <dan.carpenter@...cle.com> CC: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>, Tomi Valkeinen <tomi.valkeinen@...com>, linux-fbdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH] au1100fb: Delete unnecessary checks before two function calls >> The functions clk_enable() and clk_disable() test whether their argument >> is NULL and then return immediately. > > This isn't true for clk_enable(). I stumble on an interesting name space issue once more. > It's frustrating that you make the same mistake over and over > and you are fine with doing that. I admit that there can be also risks with my update suggestions in similar ways to contributions from other software developers. A specific function implementation exists which performs also input parameter validation. http://lxr.free-electrons.com/source/drivers/sh/clk/core.c#L291 Such variants might not fit to the functions au1100fb_drv_suspend() and au1100fb_drv_resume(). Do you want that I send a reduced patch? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists