linux-kernel - Re: [PATCH] usb: gadget: function/uvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2766164.9ZDvr0n94s@avalon>
Date:	Thu, 05 Feb 2015 17:06:22 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Lad Prabhakar <prabhakar.csengg@...il.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings

Hi Prabhakar,

Thank you for the patch.

On Thursday 05 February 2015 13:16:26 Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
> this patch fixes following sparse warnings:
> 
> uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared.
> Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was
> not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>

Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

Felipe, could you please take this in your tree ?

> ---
>  drivers/usb/gadget/function/uvc_v4l2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/function/uvc_v4l2.c
> b/drivers/usb/gadget/function/uvc_v4l2.c index 5aad7fe..8b818fd 100644
> --- a/drivers/usb/gadget/function/uvc_v4l2.c
> +++ b/drivers/usb/gadget/function/uvc_v4l2.c
> @@ -27,6 +27,7 @@
>  #include "uvc.h"
>  #include "uvc_queue.h"
>  #include "uvc_video.h"
> +#include "uvc_v4l2.h"
> 
> /* -------------------------------------------------------------------------
>  * Requests handling

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/