linux-kernel - Re: [RFC PATCH 5/8] KEYS: exec request-key within the requesting task's init namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12365.1423149270@warthog.procyon.org.uk>
Date:	Thu, 05 Feb 2015 15:14:30 +0000
From:	David Howells <dhowells@...hat.com>
To:	Ian Kent <ikent@...hat.com>
Cc:	dhowells@...hat.com,
	Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Oleg Nesterov <onestero@...hat.com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Benjamin Coddington <bcodding@...hat.com>,
	Al Viro <viro@...IV.linux.org.uk>,
	Jeff Layton <jeff.layton@...marydata.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [RFC PATCH 5/8] KEYS: exec request-key within the requesting task's init namespace

Ian Kent <ikent@...hat.com> wrote:

> +#include <linux/fs.h>

Is that actually needed?

> +	rki = kmalloc(sizeof(*rki), GFP_KERNEL);
> +	if (!rki)
> +		return -ENOMEM;
> +
> +	if (use_ns) {
> +		tsk = umh_get_init_pid();
> +		if (IS_ERR(tsk))
> +			return PTR_ERR(tsk);

Memory leak of rki.

> +	/* If running within a container use the container namespace */
> +	if (current->nsproxy->net_ns != &init_net)

Is that a viable check?  Is it possible to have a container that shares
networking details?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/