linux-kernel - Re: [PATCH] regulator: Support different config and dev of_nodes in regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205015945.GQ21293@sirena.org.uk>
Date:	Thu, 5 Feb 2015 01:59:45 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Tim Bird <tim.bird@...ymobile.com>
Cc:	lgirdwood@...il.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Bjorn Andersson <Bjorn.Andersson@...ymobile.com>
Subject: Re: [PATCH] regulator: Support different config and dev of_nodes in
 regulator_register

On Wed, Feb 04, 2015 at 03:19:57PM -0800, Tim Bird wrote:

> Support calling regulator_register with a dev node and a config node
> with different of_nodes.  This is useful when a single driver
> wishes to register multiple child regulators.

> Without this you get silent failures allocating a supply
> for a regulator which is registered using the device node of the
> regulator's DT parent (but it's own DT node).

This is explicitly not supported; such bindings are invariably attempts
to encode the Linux MFD structure into the device tree (which isn't a
wonderful idea as the way we split things into subsystems can and does
change) or...

> charger@...0 {
>       compatible = "qcom,pm8941-charger";
>       reg = <0x1000 0x700>;
>       ....
>       chg_otg {
>           regulator_name = "chg_otg";
>           otg-supply = <&pm8941_mvs1>;
>           ...
>       }
> }

...this which just looks like the supply has been placed in the wrong
place, it should be in the parent node.  Supplies are always defined at
the package level, that way we can consistently define the bindings for
supplies for a device without having to completely support it and we
don't have to bind the same supply multiple times.  It should really be
possible to wire up the supplies based only on the schematics.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)