linux-kernel - Re: [PATCH] net/macb: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8t+p70mjOY0cCnQ=JOPAFpRLxy9vjLQCT1N99iYNxsdSg@mail.gmail.com>
Date:	Thu, 5 Feb 2015 16:22:39 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/macb: fix sparse warning

On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre <nicolas.ferre@...el.com> wrote:
> Le 05/02/2015 16:40, Lad Prabhakar a écrit :
>> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
>>
>> this patch fixes following sparse warning:
>>
>> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static?
>
> Well, actually this function doesn't need to be exported and indeed
> should be marked as static.
>
> I'm not against this patch, but removing the export macro and making it
> as static should do the trick even better.
>
Done!

[1] https://patchwork.kernel.org/patch/5785511/

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/