linux-kernel - Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1423154648.31870.81.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 05 Feb 2015 08:44:08 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Miroslav Urbanek <mu@...oslavurbanek.com>
Cc:	Steffen Klassert <steffen.klassert@...unet.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tomáš Charvát <tc@...ello.cz>,
	Jan Hejl <jh@...ello.cz>, Fan Du <fan.du@...driver.com>
Subject: Re: [PATCH] flowcache: Fix kernel panic in flow_cache_flush_task

On Thu, 2015-02-05 at 16:36 +0100, Miroslav Urbanek wrote:
> flow_cache_flush_task references a structure member flow_cache_gc_work
> where it should reference flow_cache_flush_task instead.
> 
> Kernel panic occurs on kernels using IPsec during XFRM garbage
> collection. The garbage collection interval can be shortened using the
> following sysctl settings:
> 
> net.ipv4.xfrm4_gc_thresh=4
> net.ipv6.xfrm6_gc_thresh=4
> 
> With the default settings, our productions servers crash approximately
> once a week. With the settings above, they crash immediately.
> 
> Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware")
> Reported-by: Tomáš Charvát <tc@...ello.cz>
> Tested-by: Jan Hejl <jh@...ello.cz>
> Signed-off-by: Miroslav Urbanek <mu@...oslavurbanek.com>
> ---

Nice catch !

Ok, but you do not need to cc so many people/lists

netdev is fine, and we usually CC patch author, just in case.

Acked-by: Eric Dumazet <edumazet@...gle.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/