linux-kernel - Re: 1e918876 breaks r8169 (linux-3.18+)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205165607.GB14936@louise.pinerecords.com>
Date:	Thu, 5 Feb 2015 17:56:07 +0100
From:	Tomáš Szépe <szepe@...erecords.com>
To:	Florian Westphal <fw@...len.de>
Cc:	Francois Romieu <romieu@...zoreil.com>,
	Hayes Wang <hayeswang@...ltek.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Tom Herbert <therbert@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Marco Berizzi <pupilla@...mail.com>,
	linux-kernel@...r.kernel.org
Subject: Re: 1e918876 breaks r8169 (linux-3.18+)

Ehlo,

> > Since linux-3.18.0, r8169 is having problems driving one of my add-on
> > PCIe NICs.  The interface is losing link for several seconds at a time,
> > the frequency being about once a minute when the traffic is high.
> > ...
> 
> Thanks for reporting this!  I'm no lkml subscriber and thus did not
> see earlier report.

Np, I just like my eth interfaces being up when they're supposed to be up. :)

> I'll try to reproduce this but unfortunately I am currently travelling
> and won't have access to my r8169 nic until Feb 10th.
> 
> If you're willing to experiment (not even compile tested):
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> ...

I'm happy to report this patch fixes the problem (tested on vanilla
3.18.5), and the throughput of the link seems fine in both directions,
too.

Best regards,
-- 
Tomáš Szépe <szepe@...erecords.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/