linux-kernel - Re: [PATCH] usb: dwc2: Register interrupt handler only once gadget is correctly initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D3B0B6.80201@cogentembedded.com>
Date:	Thu, 05 Feb 2015 21:04:38 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Romain Perier <romain.perier@...il.com>, johnyoun@...opsys.com
CC:	gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] usb: dwc2: Register interrupt handler only once gadget
 is correctly initialized

Hello.

On 02/05/2015 08:47 PM, Romain Perier wrote:

> Don't register interrupt handler becore usb gadget is correctly initialized.

    s/becore/before/?

> For some embedded platforms which don't have a usb-phy it crashes the driver
> because an interrupt is emitted with non-initiliazed hardware.

    s/non-initiliazed/non-initialized/.

> According to devm_request_irq documentation, an interrupt can be emitted
> at any time once the interrupt is registered, so we have to care about driver
> and hardware initialization.

> Signed-off-by: Romain Perier <romain.perier@...il.com>

[...]

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/