linux-kernel - Re: [PATCH 2/2] clk: Fix OOPS calling hlist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54D3C587.9020309@codeaurora.org>
Date:	Thu, 05 Feb 2015 11:33:27 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Alban Browaeys <alban.browaeys@...il.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	Mike Turquette <mturquette@...aro.org>
CC:	linux-kernel@...r.kernel.org, Alban Browaeys <prahal@...oo.com>
Subject: Re: [PATCH 2/2] clk: Fix OOPS calling hlist_del on an already poisoned
 hlist.

On 02/05/15 10:24, Alban Browaeys wrote:
> Put is called more than once, thus hlist_del ends up on a poisoned
> list.

Why is clk_put() called more than once on the same clk pointer? Where
does this happe

>
> Move hlist_del to the __clk_release handler managed by kref instead
> of calling it in _clk_put.
>
> Fixes: 1c8e600440c7 ("clk: Add rate constraints to clocks")
> Signed-off-by: Alban Browaeys <prahal@...oo.com>
> ---
>  drivers/clk/clk.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 8f33722..f1d4b33 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2489,6 +2489,9 @@ static void __clk_release(struct kref *ref)
>  	struct clk *clk = container_of(&core, struct clk, core);
>  	int i = core->num_parents;
>  
> +	hlist_del(&clk->child_node);
> +	clk_core_set_rate_nolock(clk->core, clk->core->req_rate);
> +
>  	kfree(core->parents);
>  	while (--i >= 0)
>  		kfree_const(core->parent_names[i]);
> @@ -2666,8 +2669,6 @@ void __clk_put(struct clk *clk)
>  
>  	clk_prepare_lock();
>  
> -	hlist_del(&clk->child_node);

Ugh we should call this clks_node or something so that we don't confuse
it with child_node in clk_core.

> -	clk_core_set_rate_nolock(clk->core, clk->core->req_rate);
>  	owner = clk->core->owner;
>  	kref_put(&clk->core->ref, __clk_release);
>  


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/