linux-kernel - Re: [PATCH v3] i2c: i2c-ocores: add common clock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150205194344.GJ15307@katana>
Date:	Thu, 5 Feb 2015 20:43:44 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Max Filippov <jcmvbkbc@...il.com>
Cc:	Peter Korsgaard <jacmet@...site.dk>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] i2c: i2c-ocores: add common clock support

> +#ifdef CONFIG_HAVE_CLK
> +	if (!IS_ERR(i2c->clk))
> +		clk_disable_unprepare(i2c->clk);
> +#endif

Ehrm, you can leave out all the #ifdeffery :) The functions are all
empty in the !HAVE_CLK scenario. The only one which might be left is the
pointer in the struct. I'll leave it to you if you want to save the
bytes or the lines of code.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)