linux-kernel - Re: [PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jK-dRTBDkF_cfVuuQRXH80r2-TVTgPZ1fDqYoVMABfaHw@mail.gmail.com>
Date:	Thu, 5 Feb 2015 13:28:22 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Hari Bathini <hbathini@...ux.vnet.ibm.com>
Cc:	Tony Luck <tony.luck@...el.com>,
	Anton Vorontsov <anton@...msg.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linuxppc-dev <linuxppc-dev@...abs.org>,
	Colin Cross <ccross@...roid.com>,
	Mahesh J Salgaonkar <mahesh@...ux.vnet.ibm.com>,
	Michael Ellerman <mpe@...erman.id.au>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Subject: Re: [PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions

On Thu, Feb 5, 2015 at 11:35 AM, Hari Bathini
<hbathini@...ux.vnet.ibm.com> wrote:
> This patch series adds pstore support on powernv platform to
> read different nvram partitions and write compressed data to
> oops-log nvram partition. As pseries platform already has
> pstore support, this series moves most of the common code
> for pseries and powernv platforms to a common file. Tested
> the patches successfully on both pseries and powernv
> platforms. Also, tested the patches successfully, on a kernel
> compiled with both CONFIG_PPC_PSERIES=y & CONFIG_PPC_POWERNV=y.
>
> Changes from v4:
> 1. Added a patch for y2038-safe code changes
>
> ---
>
> Hari Bathini (4):
>       powerpc/nvram: move generic code for nvram and pstore
>       pstore: Add pstore type id for PPC64 opal nvram partition
>       pstore: add pstore support on powernv
>       powerpc: make timestamp related code y2038-safe

Thanks! I skimmed this, and it looks good to me.

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

>
>
>  arch/powerpc/include/asm/nvram.h            |   50 ++
>  arch/powerpc/include/asm/rtas.h             |    5
>  arch/powerpc/kernel/nvram_64.c              |  677 +++++++++++++++++++++++++++
>  arch/powerpc/platforms/powernv/opal-nvram.c |   10
>  arch/powerpc/platforms/pseries/nvram.c      |  673 ---------------------------
>  fs/pstore/inode.c                           |    3
>  include/linux/pstore.h                      |    1
>  7 files changed, 754 insertions(+), 665 deletions(-)
>
> --
> -Hari
>



-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/