linux-kernel - Re: [RFC][PATCH 6/7] trace: constify filter_parse_regex(), match_records(), ftrace_match() and ftrace_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150205163154.5bfdc29c@gandalf.local.home>
Date:	Thu, 5 Feb 2015 16:31:54 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH 6/7] trace: constify filter_parse_regex(),
 match_records(), ftrace_match() and ftrace_match_record()

On Thu,  5 Feb 2015 19:56:39 +0000
Al Viro <viro@...IV.linux.org.uk> wrote:

> @@ -345,12 +346,11 @@ enum regex_type filter_parse_regex(char *buff, int *len, char **search, int *not
>  					type = MATCH_MIDDLE_ONLY;
>  				else
>  					type = MATCH_FRONT_ONLY;
> -				buff[i] = 0;
>  				break;
>  			}
>  		}
>  	}
> -	*len = strlen(*search);
> +	*len = buff + i - *search;

Heh, I guess I didn't need to mention this optimization. I would
recommend that this change goes into patch 5/7. No need to place it
here. It fits better with the previous patch.

-- Steve

>  
>  	return type;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/