linux-kernel - Re: linux-next: Tree for Feb 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUXkv2JV0kurGdvOPPavyrY2hb9rjTZ1yQn13gai=qobcw@mail.gmail.com>
Date:	Thu, 5 Feb 2015 22:45:59 +0100
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Dave Hansen <dave@...1.net>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	linux-next <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Kristen Carlson Accardi <kristen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>
Subject: Re: linux-next: Tree for Feb 4

[...]
>>> >> Unfortunately, the call-trace remains when doing an offlining of cpu1.
>>> >> ( It's good to see it's reproducible. )
>>> >
>>> > Was the tracepoint enabled? Or was there some other rcu call that
>>> > triggered this. Or would cpu_online(smp_processor_id()) return true at
>>> > this point?
>>> >
>>>
>>> Thanks Steve for jumping into this one!
>>>
>>> Good point.
>>> I looked at my kernel-config (which I already sent :-)).
>>>
>>> Do I need to enable...?
>>>
>>> # CONFIG_RCU_TRACE is not set
>>>
>>> ...or even more?
>>>
>>
>> What I meant by the tracepoint being enabled, was not that it was
>> configured in (I'm assuming it was), but that you started tracing?
>>
>>  echo 1 > /sys/kernel/debug/tracing/events/enable
>>
>> or
>>
>>  echo 1 > /sys/kernel/debug/tracing/events/tlb/tlb_flushed/enable
>>
>
> NO, I did not start any tracing before doing my testing.
>
> # cat /sys/kernel/debug/tracing/events/enable
> 0
>
> # echo 1 > /sys/kernel/debug/tracing/events/enable
>
> # cat /sys/kernel/debug/tracing/events/enable
> X
>
> # LC_ALL=C cat /sys/kernel/debug/tracing/events/tlb/tlb_flushed/enable
> cat: /sys/kernel/debug/tracing/events/tlb/tlb_flushed/enable: No such
> file or directory
>
> Looks like I need to enable...?
>
> # CONFIG_DEBUG_TLBFLUSH is not set
>

Here my new kernel-config (not sure if I really need them to be enabled):

$ ./scripts/diffconfig
/boot/config-3.19.0-rc7-next-20150204.7-iniza-small
/boot/config-3.19.0-rc7-next-20150204.9-iniza-small
 DEBUG_TLBFLUSH n -> y
 RCU_TRACE n -> y
 TREE_RCU_TRACE n -> y

Steve, this was a typo it's called tlb_flush not tlb_flush*ed*:

# cat /sys/kernel/debug/tracing/events/tlb/tlb_flush/enable
1

[  391.090381] intel_pstate CPU 1 exiting
[  391.104491] smpboot: CPU 1 is now offline

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/