linux-kernel - Re: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set kprobes_all_disarmed earlier to enable re-optimization.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150205144954.d93eda6ba8be265e23037799@linux-foundation.org>
Date:	Thu, 5 Feb 2015 14:49:54 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
Cc:	Ingo Molnar <mingo@...nel.org>, tixy@...aro.org,
	Wang Nan <wangnan0@...wei.com>, linux@....linux.org.uk,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	lizefan@...wei.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH -tip/urgent 1/2] [BUGFIX]kprobes: set
 kprobes_all_disarmed earlier to enable re-optimization.

On Fri, 23 Jan 2015 15:42:24 +0900 Masami Hiramatsu <masami.hiramatsu.pt@...achi.com> wrote:

> From: Wang Nan <wangnan0@...wei.com>
> 
> In original code, the probed instruction doesn't get optimized after
> 
> echo 0 > /sys/kernel/debug/kprobes/enabled
> echo 1 > /sys/kernel/debug/kprobes/enabled
> 
> This is because original code checks kprobes_all_disarmed in
> optimize_kprobe(), but this flag is turned off after calling that
> function. Therefore, optimize_kprobe() will see
> kprobes_all_disarmed == true and doesn't do the optimization.
> 
> This patch simply turns off kprobes_all_disarmed earlier to enable
> optimization.
> 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

You sent the patches, so this should have been "Signed-off-by:". 
Documentation/SubmittingPatches section 12 has the details.

I have made that change to my copy of these two patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/