linux-kernel - Re: [RFC][PATCH 0/7] Start adding timetests to selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALAqxLVW4EYKHFWZikQtU33PNAgkNW3BiHBBm8hvc48LttKzvw@mail.gmail.com>
Date:	Thu, 5 Feb 2015 15:27:57 -0800
From:	John Stultz <john.stultz@...aro.org>
To:	Shuah Khan <shuahkh@....samsung.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Prarit Bhargava <prarit@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Richard Cochran <richardcochran@...il.com>
Subject: Re: [RFC][PATCH 0/7] Start adding timetests to selftest

On Thu, Feb 5, 2015 at 2:13 PM, Shuah Khan <shuahkh@....samsung.com> wrote:
> On 02/04/2015 11:37 PM, John Stultz wrote:
>> I've maintained a suite of timekeeping and timer tests for awhile
>> here: https://github.com/johnstultz-work/timetests
>>
>> I've been meaning to get them reworked and submitted into the
>> selftest infrastructure, but haven't had much time recently.
>>
>> I'm going to have a long flight coming up so I figured I'd
>> get started and get some initial feedback.
>>
>> This series adds all the non-destructive tests from my
>> timetests suite. The suite has more tests which actually tweak
>> time state and validate things behave as expected, but I wasn't
>> sure how to integrate that into the selftest infrastructure
>> as I'm not sure everyone would want the tests to be mucking
>> with their system time. (Currently my plan is to add a
>> script similar to the runall.sh in timetests, so folks
>> can go in and manually run it if they're feeling daring)
>
> Providing a way to run destructive tests as a special
> option is great. Non-destructive tests can be run in
> default mode.
>
> Thanks for the tests. Looks good to me. I am in the middle
> of review at the moment, will send you comments if any.

Yea, I realized after sending it that I didn't checkpatch things and
there's a bunch of style issues to be resolved. I've already fixed up
most of those, and will re-submit next week.

If you have any other feedback (other then white-space/style quirks),
do let me know and I'll also try to add that in.

I know its close to the merge window, and I'm in no rush to get these
in for 3.20, but wanted to send them out for initial thoughts now
because doing this has been on my list since kernel summit and was
finally able to steal a few evening hours to start and hopefully get
some momentum going on it. :)

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/