linux-kernel - RE: [PATCH 1/2] infiniband: cxgb4: Fix some format strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Feb 2015 17:44:03 -0600
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'Rasmus Villemoes'" <linux@...musvillemoes.dk>,
	"'Steve Wise'" <swise@...lsio.com>,
	"'Roland Dreier'" <roland@...nel.org>,
	"'Sean Hefty'" <sean.hefty@...el.com>,
	"'Hal Rosenstock'" <hal.rosenstock@...il.com>
Cc:	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] infiniband: cxgb4: Fix some format strings

Acked-by: Steve Wise <swise@...ngridcomputing.com>

> -----Original Message-----
> From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-owner@...r.kernel.org] On Behalf Of Rasmus Villemoes
> Sent: Thursday, February 05, 2015 5:33 PM
> To: Steve Wise; Roland Dreier; Sean Hefty; Hal Rosenstock
> Cc: Rasmus Villemoes; linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 1/2] infiniband: cxgb4: Fix some format strings
> 
> PDBG prepends MOD (which expands to "iw_cxgb4" ":") to the format
> string. So the KERN_INFO just ends up in the middle where it just
> garbles the output. At the same place, there's obviously no reason to
> add MOD explicitly.
> 
> The two other are straight-forward fixes of KERN_ERR KERN_ERR, where
> the second will end up as garbage in the output.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  drivers/infiniband/hw/cxgb4/device.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index eb5df4e62703..536356a8c58c 100644
> --- a/drivers/infiniband/hw/cxgb4/device.c
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -979,7 +979,7 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop)
>  		}
>  	}
> 
> -	PDBG(KERN_INFO MOD "ocq memory: "
> +	PDBG("ocq memory: "
>  	       "hw_start 0x%x size %u mw_pa 0x%lx mw_kva %p\n",
>  	       devp->rdev.lldi.vr->ocq.start, devp->rdev.lldi.vr->ocq.size,
>  	       devp->rdev.oc_mw_pa, devp->rdev.oc_mw_kva);
> @@ -1368,7 +1368,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
>  					  t4_sq_host_wq_pidx(&qp->wq),
>  					  t4_sq_wq_size(&qp->wq));
>  		if (ret) {
> -			pr_err(KERN_ERR MOD "%s: Fatal error - "
> +			pr_err(MOD "%s: Fatal error - "
>  			       "DB overflow recovery failed - "
>  			       "error syncing SQ qid %u\n",
>  			       pci_name(ctx->lldi.pdev), qp->wq.sq.qid);
> @@ -1384,7 +1384,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list)
>  					  t4_rq_wq_size(&qp->wq));
> 
>  		if (ret) {
> -			pr_err(KERN_ERR MOD "%s: Fatal error - "
> +			pr_err(MOD "%s: Fatal error - "
>  			       "DB overflow recovery failed - "
>  			       "error syncing RQ qid %u\n",
>  			       pci_name(ctx->lldi.pdev), qp->wq.rq.qid);
> --
> 2.1.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/