linux-kernel - Re: [PATCH] cifs: smb2_clone_range()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAH2r5muyAvy-Me52_oFmC4SZ8MtsYgjXMmCc9Xnyu=6=B0e2kw@mail.gmail.com>
Date:	Fri, 6 Feb 2015 00:05:34 -0600
From:	Steve French <smfrench@...il.com>
To:	Sachin Prabhu <sprabhu@...hat.com>
Cc:	linux-cifs <linux-cifs@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: smb2_clone_range() - exit on unhandled error

Merged into cifs-2.6.git

On Wed, Feb 4, 2015 at 7:10 AM, Sachin Prabhu <sprabhu@...hat.com> wrote:
> While attempting to clone a file on a samba server, we receive a
> STATUS_INVALID_DEVICE_REQUEST. This is mapped to -EOPNOTSUPP which
> isn't handled in smb2_clone_range(). We end up looping in the while loop
> making same call to the samba server over and over again.
>
> The proposed fix is to exit and return the error value when encountered
> with an unhandled error.
>
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Sachin Prabhu <sprabhu@...hat.com>
> ---
>  fs/cifs/smb2ops.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
> index 96b5d40..eab05e1 100644
> --- a/fs/cifs/smb2ops.c
> +++ b/fs/cifs/smb2ops.c
> @@ -684,7 +684,8 @@ smb2_clone_range(const unsigned int xid,
>
>                         /* No need to change MaxChunks since already set to 1 */
>                         chunk_sizes_updated = true;
> -               }
> +               } else
> +                       goto cchunk_out;
>         }
>
>  cchunk_out:
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/