linux-kernel - Re: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150206104917.GB3220@pd.tnic>
Date:	Fri, 6 Feb 2015 11:49:17 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Parmeshwr Prasad <parmeshwr_prasad@...l.com>
Cc:	Matt Fleming <matt@...sole-pimps.org>,
	Dave Young <dyoung@...hat.com>,
	Jon Masters <jonathan@...masters.org>,
	Laszlo Ersek <lersek@...hat.com>,
	linux-efi <linux-efi@...r.kernel.org>,
	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Ricardo Neri <ricardo.neri-calderon@...ux.intel.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] efi, x86: Add a "debug" option to the efi= cmdline

On Fri, Feb 06, 2015 at 01:00:12AM -0500, Parmeshwr Prasad wrote:
> I am really sorry that I could not mentioned for what purpose this patch is .
> I wanted this patch to be included along with your patch.  As your patch is 
> To add “debug” cmdline in efi=”<option>”.
> 
> There are some messages in efifb which appears while booting. I thought of
> Putting that messages under efi=”debug” cmdline. When efi=debug is given 
> Then only efifb messages should appear.

This is not how we do patches. If you feel that those printks in efifb
are too verbose and should be behind a debug switch or, even removed
completely, you can do a separate patch as I explained to you and write
in that commit message what needs to be done and *why* you think it
should be done.

HTH.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/