linux-kernel - Re: [PATCH 1/2] xenbus_client: extend interface to suppurt multi-page ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150206105730.GB30821@zion.uk.xensource.com>
Date:	Fri, 6 Feb 2015 10:57:30 +0000
From:	Wei Liu <wei.liu2@...rix.com>
To:	Bob Liu <bob.liu@...cle.com>
CC:	<xen-devel@...ts.xen.org>, <david.vrabel@...rix.com>,
	<linux-kernel@...r.kernel.org>, <roger.pau@...rix.com>,
	<konrad.wilk@...cle.com>, <boris.ostrovsky@...cle.com>,
	<wei.liu2@...rix.com>
Subject: Re: [PATCH 1/2] xenbus_client: extend interface to suppurt
 multi-page ring

On Fri, Jan 23, 2015 at 06:14:30PM +0800, Bob Liu wrote:
[...]
>  	rv = xenbus_alloc_evtchn(dev, &priv->evtchn);
>  	if (rv)
> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
> index 908e65e..8513764 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1955,7 +1955,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	int err = -ENOMEM;
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     tx_ring_ref, &addr);
> +				&tx_ring_ref, 1, &addr);
>  	if (err)
>  		goto err;
>  
> @@ -1963,7 +1963,7 @@ int xenvif_map_frontend_rings(struct xenvif_queue *queue,
>  	BACK_RING_INIT(&queue->tx, txs, PAGE_SIZE);
>  
>  	err = xenbus_map_ring_valloc(xenvif_to_xenbus_device(queue->vif),
> -				     rx_ring_ref, &addr);
> +				&rx_ring_ref, 1, &addr);

With my netback maintainer hat on, indentation here looks wrong. Not
sure if this is my fault when writing the original patch, but it would
be good if you fix them in next posting. :-)

Thanks
Wei.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/