linux-kernel - Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu_ExGUkr0AJS4uSHLuz3LxO+x8sxnsnmDAYfVRAgHGXBA@mail.gmail.com>
Date:	Fri, 6 Feb 2015 11:08:51 +0000
From:	Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Al Stone <al.stone@...aro.org>,
	Mark Langsdorf <mlangsdo@...hat.com>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
	Will Deacon <Will.Deacon@....com>,
	"wangyijing@...wei.com" <wangyijing@...wei.com>,
	Rob Herring <robh@...nel.org>,
	Timur Tabi <timur@...eaurora.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"msalter@...hat.com" <msalter@...hat.com>,
	"phoenix.liyi@...wei.com" <phoenix.liyi@...wei.com>,
	Robert Richter <rric@...nel.org>,
	Jason Cooper <jason@...edaemon.net>,
	Arnd Bergmann <arnd@...db.de>,
	Marc Zyngier <Marc.Zyngier@....com>,
	"jcm@...hat.com" <jcm@...hat.com>, Mark Brown <broonie@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Ashwin Chaugule <ashwinc@...eaurora.org>,
	Randy Dunlap <rdunlap@...radead.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Olof Johansson <olof@...om.net>
Subject: Re: [Linaro-acpi] [PATCH v8 02/21] acpi: fix acpi_os_ioremap for arm64

On 6 February 2015 at 10:36, Catalin Marinas <catalin.marinas@....com> wrote:
> On Thu, Feb 05, 2015 at 10:16:03PM +0000, Ard Biesheuvel wrote:
>> On 5 February 2015 at 17:48, Catalin Marinas <catalin.marinas@....com> wrote:
>> > On Thu, Feb 05, 2015 at 04:42:19PM +0000, Al Stone wrote:
>> >> On 02/05/2015 06:54 AM, Mark Salter wrote:
>> >> > On Thu, 2015-02-05 at 10:41 +0000, Catalin Marinas wrote:
>> >> >> On Wed, Feb 04, 2015 at 06:58:14PM +0000, Mark Salter wrote:
>> >> >>> On Wed, 2015-02-04 at 17:57 +0000, Catalin Marinas wrote:
>> >> >>>> On Wed, Feb 04, 2015 at 04:08:27PM +0000, Mark Salter wrote:
>> >> >>>>> acpi_os_remap() is used to map ACPI tables. These tables may be in ram
>> >> >>>>> which are already included in the kernel's linear RAM mapping. So we
>> >> >>>>> need ioremap_cache to avoid two mappings to the same physical page
>> >> >>>>> having different caching attributes.
>> >> >>>>
>> >> >>>> What's the call path to acpi_os_ioremap() on such tables already in the
>> >> >>>> linear mapping? I can see an acpi_map() function which already takes
>> >> >>>> care of the RAM mapping case but there are other cases where
>> >> >>>> acpi_os_ioremap() is called directly. For example,
>> >> >>>> acpi_os_read_memory(), can it be called on both RAM and I/O?
>> >> >>>
>> >> >>> acpi_map() is the one I've seen.
>> >> >>
>> >> >> By default, if should_use_kmap() is not patched for arm64, it translates
>> >> >> to page_is_ram(); acpi_map() would simply use a kmap() which returns the
>> >> >> current kernel linear mapping on arm64.
>> >> >
>> >> > The problem with kmap() is that it only maps a single page. I've seen
>> >> > tables over 4k which is why I patched acpi_map() not to use kmap() on
>> >> > arm64.
>> >>
>> >> Right.  Mark replied to this before I could; using kmap() enforced a 4k
>> >> (one page) limit that we kept breaking with some ACPI tables being larger
>> >> than that (DSDTs and SSDTs, fwiw).  This would lead to some very odd behaviors
>> >> when most but not all of a device definition was within the page; using the
>> >> table checksums was one way of detecting the issues.
>> >
>> > OK. So I think Mark's original patch was ok, assuming that the System
>> > Memory cases mentioned by Graeme are detected with page_is_ram().
>>
>> page_is_ram() returns whether a pfn is covered by the linear mapping,
>> so memory before the kernel or after a mem= limit will be
>> misidentified.
>
> OK. So in conclusion acpi_os_ioremap() may need to create a cacheable
> mapping even when !page_is_ram() but it has no way of knowing that
> unless we change the core ACPI code to differentiate between
> ioremap_cache and ioremap_nocache. Did I get it right?
>

Yes and no. Your analysis about the core issue is correct, but it is
something we can fix on our end if we like.
This issue has been on our radar for a while, and we proposed a way to
fix it here

http://thread.gmane.org/gmane.linux.kernel.efi/5133

(The 'other series' the cover letter refers to is the virtmap series
you pulled for 3.20)

There is a known issue on APM with this series, reported by Dave
Young, and I was hoping digging into that next week at Connect.

-- 
Ard.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/