linux-kernel - Re: [PATCH] fs: jffs2: Remove utf8 from printk string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1423232860.26461.93.camel@infradead.org>
Date:	Fri, 06 Feb 2015 14:27:40 +0000
From:	David Woodhouse <dwmw2@...radead.org>
To:	Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: jffs2: Remove utf8 from printk string

On Fri, 2015-02-06 at 15:19 +0100, Rasmus Villemoes wrote:
> Any non-ascii characters are escaped before being show to user-space,
> so this shows up as
> 
> jffs2: version 2.2. (NAND) \xffffffc2\xffffffa9\xffffffa9 2001-2006
> Red Hat, Inc.
> 
> (I have no idea why the second byte is repeated.) Replace with a
> widely used ascii replacement.

Nah. Fix the bug, don't apply a crappy workaround. This is the 21st
century.

> Actually, I don't see the value in printing a copyright notice to the
> kernel log, especially since it's out-of-sync with the one at the top
> of the file.

Agreed. Removing it would be better than the crappy workaround. But
let's use it as a test case to fix the *real* bug first.

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5745 bytes)