linux-kernel - Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEUsAPa6+nmooA0DAt9dFTgaYqBCxRaLVPge71gWOfYY=P_yYw@mail.gmail.com>
Date:	Fri, 6 Feb 2015 09:07:40 -0600
From:	Chris Rorvick <chris@...vick.com>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Stefan Hajnoczi <stefanha@...il.com>
Subject: Re: [PATCH 1/4] ALSA: line6: Add toneport_has_source_select()

On Fri, Feb 6, 2015 at 8:56 AM, Takashi Iwai <tiwai@...e.de> wrote:
> At Fri,  6 Feb 2015 08:51:09 -0600, Chris Rorvick wrote:
>> --- a/sound/usb/line6/toneport.c
>> +++ b/sound/usb/line6/toneport.c
>> @@ -343,6 +343,20 @@ static void toneport_remove_leds(struct usb_line6_toneport *toneport)
>>       }
>>  }
>>
>> +static bool toneport_has_source_select(struct usb_line6_toneport *toneport)
>> +{
>> +     switch (toneport->type) {
>> +     case LINE6_TONEPORT_UX1:
>> +     case LINE6_TONEPORT_UX2:
>> +     case LINE6_PODSTUDIO_UX1:
>> +     case LINE6_PODSTUDIO_UX2:
>> +             return 1;
>> +
>> +     default:
>> +             return 0;
>
> Please use true and false.

Thanks, I've fixed this up and will send in a v2.

Regards,

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/