linux-kernel - Re: [PATCH V2] x86, mce, amd: Enable interrupts by default if HW capable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150206163837.GI3220@pd.tnic>
Date:	Fri, 6 Feb 2015 17:38:37 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
Cc:	tony.luck@...el.com, mingo@...hat.com, tglx@...utronix.de,
	hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org,
	linux-edac@...r.kernel.org
Subject: Re: [PATCH V2] x86, mce, amd: Enable interrupts by default if HW
 capable

On Mon, Feb 02, 2015 at 11:02:41AM -0600, Aravind Gopalakrishnan wrote:
> We setup APIC vectors for threshold errors if interrupt_capable.
> However, we don't set interrupt_enable by default.
> Re-working threshold_restart_bank() here so that the first time we
> set up lvt_offset, we also set IntType to APIC.
> 
> User is still allowed to disable interrupts through sysfs.
> 
> While at it, check if status is valid before we proceed to log
> error using mce_log. This is because, in multi-node platforms,
> only NBC has valid status info. So, the decoding of status values
> on the non-NBC leads to noise on kernel logs like so-
> 
> [  440.509744] EDAC DEBUG: amd64_inject_write_store: section=0x80000000
> word_bits=0x10020001
> [  466.570925] [Hardware Error]: Corrected error, no action required.
> [  466.570935] [Hardware Error]: CPU:25 (15:2:0) MC4_STATUS[-|CE|-|-|-
> [  466.570936] [Hardware Error]: Corrected error, no action required.
> [  466.570959] [Hardware Error]: CPU:26 (15:2:0) MC4_STATUS[-|CE|-|-|-
> <...>
> [  466.571293] WARNING: CPU: 25 PID: 0 at drivers/edac/amd64_edac.c:2147
> decode_bus_error+0x1ba/0x2a0()
> [  466.571301] WARNING: CPU: 26 PID: 0 at drivers/edac/amd64_edac.c:2147
> decode_bus_error+0x1ba/0x2a0()
> [  466.571303] Something is rotten in the state of Denmark.
> 
> Suggested-by: Borislav Petkov <bp@...e.de>
> Signed-off-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>

Queued for 3.21, thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/