linux-kernel - Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D4FBAC.8000605@codeaurora.org>
Date:	Fri, 06 Feb 2015 09:36:44 -0800
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Mike Turquette <mturquette@...aro.org>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>
CC:	linux-kernel@...r.kernel.org,
	Alban Browaeys <alban.browaeys@...il.com>,
	Beata Michalska <b.michalska@...sung.com>
Subject: Re: [PATCH v2] clkdev: Always allocate a struct clk and call __clk_get()
 w/ CCF

On 02/06/15 02:57, Sylwester Nawrocki wrote:
>
> As a side note, IMHO recent changes made the code much harder to follow,
> e.g. by using 'clk' local variable name interchangeably for 'struct clk'
> and 'struct clk_core' types and by using same field name in different data
> structures, like 'child_node'. I guess the changes were limited to make
> the diff smaller, nevertheless it seems we ended up with something rather
> illegible.

Yes it was to reduce diff. I plan to do the rename once the dust settles.

>
> Tested-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
>
>

Thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/