linux-kernel - Re: [RFC][PATCH v2 6/7] trace: constify filter_parse_regex(), match_records(), ftrace_match() and ftrace_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150206135639.71ac6324@gandalf.local.home>
Date:	Fri, 6 Feb 2015 13:56:39 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH v2 6/7] trace: constify filter_parse_regex(),
 match_records(), ftrace_match() and ftrace_match_record()

On Fri,  6 Feb 2015 04:00:14 +0000
Al Viro <viro@...IV.linux.org.uk> wrote:

> +				   const char **search, int *not)
>  {
>  	int type = MATCH_FULL;
>  	int i;
> @@ -345,12 +346,11 @@ enum regex_type filter_parse_regex(char *buff, int *len, char **search, int *not
>  					type = MATCH_MIDDLE_ONLY;
>  				else
>  					type = MATCH_FRONT_ONLY;
> -				buff[i] = 0;
>  				break;
>  			}
>  		}
>  	}
> -	*len = strlen(*search);
> +	*len = buff + i - *search;

This change belongs in the previous patch.

-- Steve

>  
>  	return type;
>  }
> @@ -358,7 +358,7 @@ enum regex_type filter_parse_regex(char *buff, int *len, char **search, int *not
>  static void filter_build_regex(struct filter_pred *pred)
>  {
>  	struct regex *r = &pred->regex;
> -	char *search;
> +	const char *search;
>  	enum regex_type type = MATCH_FULL;
>  	int not = 0;
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/