linux-kernel - gpio-pxa: getting GPIOs by devicetree phandle broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOjnSCajhwdRVZUO99KL-9PF6HitZen04MoLKoDUDr_5=iS7kw@mail.gmail.com>
Date:	Fri, 6 Feb 2015 16:28:09 -0500
From:	Tyler Hall <tylerwhall@...il.com>
To:	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Cc:	Daniel Mack <zonque@...il.com>,
	Hans Holmberg <hans.holmberg@...el.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-kernel@...r.kernel.org, Howard Cochran <cochran@...mark.com>
Subject: gpio-pxa: getting GPIOs by devicetree phandle broken

Hi,

Commit 7b8792b ("gpiolib: of: Correct error handling in
of_get_named_gpiod_flags") seems to break the ability to use DT
bindings to reference this driver's GPIOs by phandle for banks above
the first.

The issue is that gpio-pxa registers multiple gpio chips - one for
each bank - but they're all associated with the same DT node. The new
behavior in of_gpiochip_find_and_xlate() causes gpiochip_find() to
bail after the first chip matches and its xlate function fails.
Previously it would try all chips associated with the phandle and
pxa_gpio_of_xlate() would fail until it was called with the correct
gpiochip.

I think the new behavior of of_gpiochip_find_and_xlate() is reasonable,
so I see a couple ways of fixing gpio-pxa.

1. Require child nodes in DT for each bank
2. Refactor gpio-pxa to only register one gpiochip

There was a previously undocumented binding that required child nodes
but it was removed by 5dbb7c6 ("gpio: pxa: remove dead code"). It's
still present in the DT files that use "marvell,mmp-gpio." Here's an
example from pxa168.dtsi.

            gpio@...19000 {
                compatible = "marvell,mmp-gpio";
                #address-cells = <1>;
                #size-cells = <1>;

                ...

                gcb0: gpio@...19000 {
                    reg = <0xd4019000 0x4>;
                };
                ...
            };

I may proceed with option 1 since there's some precedent, but I'd
appreciate any input.

Thanks,
Tyler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/