lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Feb 2015 14:48:31 -0800 From: Dmitry Torokhov <dtor@...omium.org> To: Kevin Cernekee <cernekee@...omium.org> Cc: Ray Jui <rjui@...adcom.com>, Wolfram Sang <wsa@...-dreams.de>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Arend van Spriel <arend@...adcom.com>, Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>, Mark Rutland <mark.rutland@....com>, Ian Campbell <ijc+devicetree@...lion.org.uk>, Kumar Gala <galak@...eaurora.org>, Grant Likely <grant.likely@...aro.org>, Christian Daudt <bcm@...thebug.org>, Matt Porter <mporter@...aro.org>, Florian Fainelli <f.fainelli@...il.com>, Russell King <linux@....linux.org.uk>, Scott Branden <sbranden@...adcom.com>, linux-i2c@...r.kernel.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-arm-kernel@...ts.infradead.org, bcm-kernel-feedback-list@...adcom.com, devicetree@...r.kernel.org, Dmitry Torokhov <dtor@...omium.org> Subject: Re: [v7,2/3] i2c: iproc: Add Broadcom iProc I2C Driver On Fri, Feb 6, 2015 at 2:31 PM, Kevin Cernekee <cernekee@...omium.org> wrote: > On Mon, Jan 19, 2015 at 01:51:49PM -0800, Ray Jui wrote: >> + >> + dev_dbg(iproc_i2c->device, "xfer %c, addr=0x%02x, len=%d\n", >> + (msg->flags & I2C_M_RD) ? 'R' : 'W', msg->addr, >> + msg->len); >> + dev_dbg(iproc_i2c->device, "**** data start ****\n"); >> + for (i = 0; i < msg->len; i++) >> + dev_dbg(iproc_i2c->device, "0x%02x ", msg->buf[i]); >> + dev_dbg(iproc_i2c->device, "**** data end ****\n"); > > It might be simpler to just do: > > print_hex_dump_bytes("iproc_i2c:", DUMP_PREFIX_NONE, msg->buf, msg->len); > > although you'd lose the ability to see the I2C device name. We can also do: dev_dbg(iproc_i2c->device, "*** data: %*ph\n", msg->len, msg->buf); if we are OK with limiting output to 64 bytes. Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists