linux-kernel - Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKXHbyP5HUq7SAkJ3bSwN==tSwbkoWdqH5YPjWz1htx5GxaGaA@mail.gmail.com>
Date:	Sat, 7 Feb 2015 14:04:58 +0100
From:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Chaitanya Hazarey <c@...io>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Donald <gdonald@...il.com>,
	Koray Gulcu <koray.gulcu@....edu.tr>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null
 pointer dereference

2015-02-06 15:32 GMT+01:00 Sudip Mukherjee <sudipm.mukherjee@...il.com>:
> On Thu, Feb 05, 2015 at 06:39:13PM +0100, Rickard Strandqvist wrote:
>> 2015-02-05 13:51 GMT+01:00 Dan Carpenter <dan.carpenter@...cle.com>:
>> > On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
>> >> if (driver_info) {
>> >>       stats->RxIs40MHzPacket = driver_info->BW;
>> >>       if (stats->RxDrvInfoSize != 0)
>> >>               TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
>> >> }
>> >
>> > If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and
>> > also the reverse.  So really you only need to test one.
>> >
>> > regards,
>> > dan carpenter
>> >
>>
>> True Dan
>>
>> Okay, I'll make one last patch then, or if you want to do it Sudip?
>> Have you not done before Saturday I do it.
> no, its yours. you found it so credit should be yours.
> I am sure Greg will accept this one. If he drops then maybe I can re-send with you as Reported-by
>
> regards
> Sudip
>
>>
>> Kind regards
>> Rickard Strandqvist


Thanks Sudip :)

And after checking some more, I agree with Dan cleaner to only use
if(driver_info)

New patch coming soon.

Kind regards
Rickard Strandqvist
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/