linux-kernel - Re: [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix brace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1502072014420.2050@localhost6.localdomain6>
Date:	Sat, 7 Feb 2015 20:15:21 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Bas Peters <baspeters93@...il.com>
cc:	isdn@...ux-pingi.de, julia.lawall@...6.fr, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix
 brace

On Sat, 7 Feb 2015, Bas Peters wrote:

> This patch adds the \ that was accidentally deleted in patch 2. It also adds a brace after the else statement, which is required due to the fact that the if statement has braces.

You should fix the patch that was incorrect, rather than submitting a 
patch that does something incorrect and then another patch to fix it.  The 
kernel should compile after every patch.

julia

> 
> ---
>  drivers/isdn/act2000/capi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/isdn/act2000/capi.c b/drivers/isdn/act2000/capi.c
> index 5d677e6..0043b3c 100644
> --- a/drivers/isdn/act2000/capi.c
> +++ b/drivers/isdn/act2000/capi.c
> @@ -113,8 +113,9 @@ actcapi_chkhdr(act2000_card *card, actcapi_msghdr *hdr)
>  			m->hdr.cmd.cmd = c;			\
>  			m->hdr.cmd.subcmd = s;			\
>  			m->hdr.msgnum = actcapi_nextsmsg(card); \
> -		} else
> +		} else {					\
>  			m = NULL;				\
> +		}						\
>  	}
>  
>  #define ACTCAPI_CHKSKB if (!skb) {					\
> -- 
> 2.1.0
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/