linux-kernel - Re: [PATCH] Sony-laptop: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 7 Feb 2015 12:07:10 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	Bjørn Mork <bjorn@...k.no>
Cc:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>,
	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>,
	Mattia Dongili <malattia@...ux.it>,
	platform-driver-x86@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] Sony-laptop: fix sparse warning

On Sat, Feb 07, 2015 at 12:33:16PM +0100, Bjørn Mork wrote:
> Darren Hart <dvhart@...radead.org> writes:
> > On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> >
> >> Lad, Prabhakar <prabhakar.lad@...com>
> >> Lad, Prabhakar <prabhakar.csengg@...il.com>
> >
> > I think there may be a problem with this in an unquoted email address. The
> > unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
> > and . separators.
> 
> Yes, but that is not applicable to the git commit tags.  They are not
> RFC2822 header fields.  Nothing will ever parse "Lad" as an unqualified
> local destination in a SOB, and therefore there is no problem using the
> comma there.

Also, my reading was incorrect as "local part" refers to the text preceeding
the @ character, not the text outside the <>. So, while the name should probably
be quoted to avoid problems with MUAs interpretting the , as a list separator, I
don't have anything definitive to reference to prevent it. So at least for now,
I'll be accepting Lad's contributions as is, comma and all :-)

I really dislike this aspect of our tooling. Being so free form, it's
inevitiable for even seasoned contributors to trip over these sort of implicit
rules. It seems to me that a very significant, perhaps not the majority, of the
time I spend as maintainer is dealing with things like coding style, commit
message formatting, and similar issues. I can sympathize with those who
criticize our mechanisms as archaic :-/

> 
> Note that names using non-ascii characters are often written without
> quotes i SOBs (wonder how I know this? :-).  In practice I believe the
> character set is only limited by what you will allow in your git log.
> The only characters with a special meaning are :<>#, and the latter is
> somewhat dubious.  But it's often used as a comment separator in stable
> CCs, so I guess it should be avoided for other uses.
> 
> Scripts etc trying to parse these tags into email headers must be
> prepared to do the necessary stripping and quoting of any text outside
> the <> brackets.
> 
> Requiring a full name is of course good for accountability, but do let
> people format their names as they want them to appear in the log.
> Different cultures have different traditions. Wookey has collected a few
> links on this subject if anyone is interested:
> http://wookware.org/name.html
> 

Thanks Bjørn :-)

> 
> Bjørn
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/