linux-kernel - Re: [PATCH] Sony-laptop: fix sparse warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150207030827.GC20934@fury.dvhart.com>
Date:	Fri, 6 Feb 2015 19:08:27 -0800
From:	Darren Hart <dvhart@...radead.org>
To:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
Cc:	Giedrius Statkevičius 
	<giedrius.statkevicius@...il.com>,
	Mattia Dongili <malattia@...ux.it>,
	platform-driver-x86@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] Sony-laptop: fix sparse warning

On Thu, Feb 05, 2015 at 04:00:32PM +0000, Lad, Prabhakar wrote:
> Hi Giedrius,
> 
> On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius
> <giedrius.statkevicius@...il.com> wrote:
> > On 2015.02.05 16:49, Lad Prabhakar wrote:
> >> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> >>
> >> this patch fixes following sparse warning:
> >>
> >> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static?
> >>
> >> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> > Don't put a comma between your first and last name, please. Also, is
> > this your real name and surname?
> >
> I have hundreds of patches with:
> 
> Lad, Prabhakar <prabhakar.lad@...com>
> Lad, Prabhakar <prabhakar.csengg@...il.com>

I think there may be a problem with this in an unquoted email address. The
unquoted local part, per RFC 2822 3.4.1, can only contain  !#$%'*+-/=?^_`{|}~
and . separators.

David Miller is the one who usually catches this sort of thing. David, do we
have a problem here?

> 
> I don’t want to change it now! Yes that's my real name.
> 
> Cheers,
> --Prabhakar
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/