linux-kernel - Re: [PATCH 2/2] iser-target: Remove duplicate function names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D7B2E8.8060000@dev.mellanox.co.il>
Date:	Sun, 08 Feb 2015 21:03:04 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>
CC:	Sagi Grimberg <sagig@...lanox.com>,
	Roland Dreier <roland@...nel.org>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma@...r.kernel.org, target-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] iser-target: Remove duplicate function names

On 2/6/2015 8:49 PM, Nicholas A. Bellinger wrote:
> On Fri, 2015-02-06 at 01:09 +0100, Rasmus Villemoes wrote:
>> The macro isert_dbg already ensures that __func__ is part of the
>> output, so there's no reason to duplicate the function name in the
>> format string itself.
>>
>> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
>> ---
>>   drivers/infiniband/ulp/isert/ib_isert.c | 7 +++----
>>   1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c
>> index dafb3c531f96..20097de9ac45 100644
>> --- a/drivers/infiniband/ulp/isert/ib_isert.c
>> +++ b/drivers/infiniband/ulp/isert/ib_isert.c
>> @@ -949,7 +949,7 @@ isert_post_recv(struct isert_conn *isert_conn, u32 count)
>>   		isert_err("ib_post_recv() failed with ret: %d\n", ret);
>>   		isert_conn->post_recv_buf_count -= count;
>>   	} else {
>> -		isert_dbg("isert_post_recv(): Posted %d RX buffers\n", count);
>> +		isert_dbg("Posted %d RX buffers\n", count);
>>   		isert_conn->conn_rx_desc_head = rx_head;
>>   	}
>>   	return ret;
>> @@ -1709,8 +1709,7 @@ isert_put_cmd(struct isert_cmd *isert_cmd, bool comp_err)
>>   		 * associated cmd->se_cmd needs to be released.
>>   		 */
>>   		if (cmd->se_cmd.se_tfo != NULL) {
>> -			isert_dbg("Calling transport_generic_free_cmd from"
>> -				 " isert_put_cmd for 0x%02x\n",
>> +			isert_dbg("Calling transport_generic_free_cmd for 0x%02x\n",
>>   				 cmd->iscsi_opcode);
>>   			transport_generic_free_cmd(&cmd->se_cmd, 0);
>>   			break;
>> @@ -3136,7 +3135,7 @@ accept_wait:
>>   	spin_lock_bh(&np->np_thread_lock);
>>   	if (np->np_thread_state >= ISCSI_NP_THREAD_RESET) {
>>   		spin_unlock_bh(&np->np_thread_lock);
>> -		isert_dbg("np_thread_state %d for isert_accept_np\n",
>> +		isert_dbg("np_thread_state %d\n",
>>   			 np->np_thread_state);
>>   		/**
>>   		 * No point in stalling here when np_thread
>
> Applied to target-pending/for-next.
>
> Thanks Rasmus!

You can add my ack if you want:

Acked-by: Sagi Grimberg <sagig@...lanox.com>

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/