linux-kernel - Re: [PATCH 1/5] virtio: define VIRTIO_PCI_CAP_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150208110023.GJ3185@redhat.com>
Date:	Sun, 8 Feb 2015 12:00:23 +0100
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] virtio: define VIRTIO_PCI_CAP_PCI_CFG in header.

On Fri, Feb 06, 2015 at 03:36:52PM +1030, Rusty Russell wrote:
> This provides backdoor access to the device MMIOs, and every device should
> have one.  From the virtio 1.0 spec (CS03):
> 
>   4.1.4.7.1 Device Requirements: PCI configuration access capability
> 
>   The device MUST present at least one VIRTIO_PCI_CAP_PCI_CFG capability.
> 
> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>

Acked-by: Michael S. Tsirkin <mst@...hat.com>

> ---
>  include/uapi/linux/virtio_pci.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/virtio_pci.h b/include/uapi/linux/virtio_pci.h
> index 3b7e4d2765fb..75301468359f 100644
> --- a/include/uapi/linux/virtio_pci.h
> +++ b/include/uapi/linux/virtio_pci.h
> @@ -109,8 +109,10 @@
>  #define VIRTIO_PCI_CAP_NOTIFY_CFG	2
>  /* ISR access */
>  #define VIRTIO_PCI_CAP_ISR_CFG		3
> -/* Device specific confiuration */
> +/* Device specific configuration */
>  #define VIRTIO_PCI_CAP_DEVICE_CFG	4
> +/* PCI configuration access */
> +#define VIRTIO_PCI_CAP_PCI_CFG		5
>  
>  /* This is the PCI capability header: */
>  struct virtio_pci_cap {
> -- 
> 2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/