linux-kernel - Re: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change type in printf format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <54D74FBF.7010000@kernel.org>
Date:	Sun, 08 Feb 2015 11:59:59 +0000
From:	Jonathan Cameron <jic23@...nel.org>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>,
	Hartmut Knaack <knaack.h@....de>
CC:	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald <pmeerw@...erw.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Joel Porquet <joel@...quet.org>,
	Darshana Padmadas <darshanapadmadas@...il.com>,
	Catalina Mocanu <catalina.mocanu@...il.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-iio@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: trigger: iio-trig-periodic-rtc: Change
 type in printf format string

On 27/01/15 21:32, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'unsigned int'
> but the argument type is 'int'
> 
> This was found using a static code analysis program called cppcheck
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Whilst you have identified a bug, I think the better fix would be to take frequency unsigned.
It is always treated as such in the driver so they type should probably reflect this.

If you want to put together such a patch that would be great. If not I'll
get to it at some point (probably!)
> ---
>  drivers/staging/iio/trigger/iio-trig-periodic-rtc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> index a24caf7..66d54a0 100644
> --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c
> @@ -52,7 +52,7 @@ static ssize_t iio_trig_periodic_read_freq(struct device *dev,
>  	struct iio_trigger *trig = to_iio_trigger(dev);
>  	struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig);
>  
> -	return sprintf(buf, "%u\n", trig_info->frequency);
> +	return sprintf(buf, "%d\n", trig_info->frequency);
>  }
>  
>  static ssize_t iio_trig_periodic_write_freq(struct device *dev,
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/