linux-kernel - Re: [PATCH v2] staging: lustre: fix coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150209073145.GD5206@mwanda>
Date:	Mon, 9 Feb 2015 10:31:45 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Tal Shorer <tal.shorer@...il.com>
Cc:	"Drokin, Oleg" <oleg.drokin@...el.com>,
	"<devel@...verdev.osuosl.org>" <devel@...verdev.osuosl.org>,
	"Dilger, Andreas" <andreas.dilger@...el.com>,
	"<gregkh@...uxfoundation.org>" <gregkh@...uxfoundation.org>,
	"<linux-kernel@...r.kernel.org>" <linux-kernel@...r.kernel.org>,
	"<clabbe.montjoie@...il.com>" <clabbe.montjoie@...il.com>,
	"<PDD-discuss@...ts.01.org>" <PDD-discuss@...1.01.org>
Subject: Re: [PATCH v2] staging: lustre: fix coding style errors in
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c

On Sun, Feb 08, 2015 at 07:57:01PM +0200, Tal Shorer wrote:
> Signed-off-by: Tal Shorer <tal.shorer@...il.com>
> ---
> Decided not to #define the constants away because their addresses are
> used later in the file.

I don't understand what this means.

> 

1) The subject is crap (which coding style issues are you fixing).
2) The subject is too long.
3) Don't put the whole path in the subject.
4) There is no patch description.

regards,
dan carpenter 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/