linux-kernel - Re: [PATCH 3/3] CRISv32: handle multiple signals

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150209020349.GA821@roeck-us.net>
Date:	Sun, 8 Feb 2015 18:03:49 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Rabin Vincent <rabin@....in>
Cc:	jesper.nilsson@...s.com, linux-cris-kernel@...s.com,
	viro@...iv.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] CRISv32: handle multiple signals

On Sun, Feb 08, 2015 at 09:45:04PM +0100, Rabin Vincent wrote:
> Al Viro noted that CRIS fails to handle multiple signals.
> 
> This fixes the problem for CRISv32 by making it use a C work_pending
> handling loop similar to the ARM implementation in 0a267fa6a15d41c
> ("ARM: 7472/1: pull all work_pending logics into C function").
> 
> This also happens to fixes the warnings which currently trigger on
> CRISv32 due to do_signal() being called with interrupts disabled.
> 
> Test case (should die of the SIGSEGV which gets raised when setting up
> the stack for SIGALRM, but instead reaches and executes the _exit(1)):
> 
>   #include <unistd.h>
>   #include <signal.h>
>   #include <sys/time.h>
>   #include <err.h>
> 
>   static void handler(int sig) { }
> 
>   int main(int argc, char *argv[])
>   {
>   	int ret;
>   	struct itimerval t1 = { .it_value = {1} };
>   	stack_t ss = {
>   		.ss_sp = NULL,
>   		.ss_size = SIGSTKSZ,
>   	};
>   	struct sigaction action = {
>   		.sa_handler = handler,
>   		.sa_flags = SA_ONSTACK,
>   	};
> 
>   	ret = sigaltstack(&ss, NULL);
>   	if (ret < 0)
>   		err(1, "sigaltstack");
> 
>   	sigaction(SIGALRM, &action, NULL);
>    	setitimer(ITIMER_REAL, &t1, NULL);
> 
>   	pause();
> 
>   	_exit(1);
> 
>   	return 0;
>   }
> 
> Reported-by: Al Viro <viro@...IV.linux.org.uk>
> Link: http://lkml.kernel.org/r/20121208074429.GC4939@ZenIV.linux.org.uk
> Signed-off-by: Rabin Vincent <rabin@....in>

Hi Rabin,

Works nicely, and, yes, it does fix the annoying traceback.

Tested-by: Guenter Roeck <linux@...ck-us.net>

Wondering - what serial driver do you use with crisv32, if any ?
So far I always patch in a cut-down version of the driver
from 2.6.26/33 which was never submitted upstream.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/