linux-kernel - RE: [PATCH v2 0/5] ACPI / EC: Add reference counting for requests and cleans up the grace periods support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E88026D4B94@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 9 Feb 2015 02:23:37 +0000
From:	"Zheng, Lv" <lv.zheng@...el.com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
CC:	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"Brown, Len" <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: RE: [PATCH v2 0/5] ACPI / EC: Add reference counting for requests
 and cleans up the grace periods support.

Hi, Rafael

> From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> Sent: Friday, February 06, 2015 9:27 AM
> 
> On Friday, February 06, 2015 08:57:37 AM Lv Zheng wrote:
> > This patchset contains 3 cleanups related to the EC driver:
> > 1. Command flushing (command grace period)
> >    This patchset flushes EC commands before suspending/resuming, so that
> >    there won't be timeout for the incomplete commands after resuming.
> > 2. Query flushing (query grace period)
> >    This patchset flushes EC event queries before suspending/resuming, so
> >    that there won't be broken events remained in the firmware queue.
> > 3. Command storming prevention
> >    This patchset corrects command storming prevention logic because of
> >    the GPE raw handler mode.
> > The request reference count debugging messages can be used to detect broken
> > EC transactions. It should always drop to 1 when the driver is idle during
> > the runtime.
> >
> > Note that after flushing before suspending, EC GPE is still enabled to keep
> > the old behavior.
> >
> > Lv Zheng (5):
> >   ACPI/EC: Introduce STARTED/STOPPED flags to replace BLOCKED flag.
> >   ACPI/EC: Add command flushing support.
> >   ACPI/EC: Refine command storm prevention support.
> >   ACPI/EC: Add query flushing support.
> >   ACPI/EC: Add GPE reference counting debugging messages.
> >
> >  drivers/acpi/ec.c       |  295 ++++++++++++++++++++++++++++++++++++++++-------
> >  drivers/acpi/internal.h |    1 +
> >  2 files changed, 254 insertions(+), 42 deletions(-)
> 
> So this is on top of the EC patches you sent previously, right?

Yes.

The sequence is:
ACPICA 20150204 release: http://www.spinics.net/lists/linux-acpi/msg55623.html
ACPI EC GPE race fixes: http://www.spinics.net/lists/linux-acpi/msg55633.html
And this series.

Thanks and best regards
-Lv


> 
> 
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.