linux-kernel - Re: [PATCH 09/13] ARM: dts: mediatek: Enable clock support for Mediatek MT8135.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150209114403.GV12209@pengutronix.de>
Date:	Mon, 9 Feb 2015 12:44:03 +0100
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
Cc:	James Liao <jamesjj.liao@...iatek.com>,
	Mike Turquette <mturquette@...aro.org>,
	YH Chen (陳昱豪) <yh.chen@...iatek.com>,
	linux-kernel@...r.kernel.org,
	Henry Chen <henryc.chen@...iatek.com>,
	Rob Herring <robh+dt@...nel.org>, kernel@...gutronix.de,
	Matthias Brugger <matthias.bgg@...il.com>,
	Yingjoe Chen (陳英洲) 
	<Yingjoe.Chen@...iatek.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 09/13] ARM: dts: mediatek: Enable clock support for
 Mediatek MT8135.

On Mon, Feb 09, 2015 at 11:27:21AM +0000, Russell King - ARM Linux wrote:
> On Mon, Feb 09, 2015 at 12:25:00PM +0100, Sascha Hauer wrote:
> > On Mon, Feb 09, 2015 at 10:51:34AM +0000, Russell King - ARM Linux wrote:
> > > On Mon, Feb 09, 2015 at 11:47:21AM +0100, Sascha Hauer wrote:
> > > > From: James Liao <jamesjj.liao@...iatek.com>
> > > > 
> > > > This patch adds MT8135 clock controllers into device tree.
> > > > @@ -86,6 +87,18 @@
> > > >  			clock-frequency = <32000>;
> > > >  			#clock-cells = <0>;
> > > >  		};
> > > > +
> > > > +		clk_null: clk_null {
> > > > +			compatible = "fixed-clock";
> > > > +			#clock-cells = <0>;
> > > > +			clock-frequency = <0>;
> > > > +		};
> > > > +
> > > > +		clk26m: clk26m {
> > > > +			compatible = "fixed-clock";
> > > > +			#clock-cells = <0>;
> > > > +			clock-frequency = <26000000>;
> > > > +		};
> > > 
> > > Is this supposed to be here?
> > 
> > The clock support needs at least the clk26m clk. Do you think it should
> > be in another patch or not present at all?
> 
> I didn't see anything which referenced either clk_null or clk26m in this
> patch.  My main concern was that clk_null, but my concern grew when I
> found that clk26m wasn't referenced either.
> 
> If the MT8135 needs it, shouldn't something in its description reference
> this clock?

It's used in the code. The mt8135 clk code directly uses the names of
these three clocks as parent_names.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/