linux-kernel - Re: [PATCH] sb_edac: Fix detection on SNB machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALCETrW6Pckk30fLR=b-S+XXhkEso-_9XGU889oTi7vfZzasXg@mail.gmail.com>
Date:	Mon, 9 Feb 2015 07:33:17 -0800
From:	Andy Lutomirski <luto@...capital.net>
To:	Mauro Carvalho Chehab <m.chehab@...sung.com>
Cc:	Aristeu Rozanski <aris@...hat.com>, Borislav Petkov <bp@...en8.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>,
	linux-edac <linux-edac@...r.kernel.org>
Subject: Re: [PATCH] sb_edac: Fix detection on SNB machines

On Mon, Feb 9, 2015 at 7:23 AM, Mauro Carvalho Chehab
<m.chehab@...sung.com> wrote:
> Em Mon, 09 Feb 2015 09:20:58 -0500
> Aristeu Rozanski <aris@...hat.com> escreveu:
>
>> On Mon, Feb 09, 2015 at 01:17:17PM +0100, Borislav Petkov wrote:
>> > From: Borislav Petkov <bp@...e.de>
>> > Subject: [PATCH] sb_edac: Fix detection on SNB machines
>> >
>> > d0585cd815fa ("sb_edac: Claim a different PCI device") changed the
>> > probing of sb_edac to look for PCI device 0x3ca0:
>> >
>> > 3f:0e.0 System peripheral: Intel Corporation Xeon E5/Core i7 Processor Home Agent (rev 07)
>> > 00: 86 80 a0 3c 00 00 00 00 07 00 80 08 00 00 80 00
>> > ...
>> >
>> > but we're matching for 0x3ca8, i.e. PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA
>> > in sbridge_probe() therefore the probing fails.
>> >
>> > Changing it to probe for 0x3ca0 (PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_HA0),
>> > .i.e., the 14.0 device, fixes the issue and driver loads successfully
>> > again:

Looks good to me, too.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/