linux-kernel - Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1423499369.2933.18.camel@perches.com>
Date:	Mon, 09 Feb 2015 08:29:29 -0800
From:	Joe Perches <joe@...ches.com>
To:	Mohammad Jamal <md.jamalmohiuddin@...il.com>
Cc:	oleg.drokin@...el.com, andreas.dilger@...el.com,
	gregkh@...uxfoundation.org, sudipm.mukherjee@...il.com,
	devel@...verdev.osuosl.org, HPDD-discuss@...ts.01.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning
 of static declaration

On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote:
> This patch adds a static keyword to variable portal_rotor to
> suppress the sparse warning of static declaration

Do please compile the subsystem before sending patches.

> diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c b/drivers/staging/lustre/lnet/lnet/lib-ptl.c
[]
> @@ -39,7 +39,7 @@
>  #include "../../include/linux/lnet/lib-lnet.h"
>  
>  /* NB: add /proc interfaces in upcoming patches */
> -int	portal_rotor	= LNET_PTL_ROTOR_HASH_RT;
> +static int	portal_rotor	= LNET_PTL_ROTOR_HASH_RT;
>  module_param(portal_rotor, int, 0644);
>  MODULE_PARM_DESC(portal_rotor, "redirect PUTs to different cpu-partitions");

$ git grep -w portal_rotor
...
drivers/staging/lustre/lnet/lnet/router_proc.c:extern int portal_rotor;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/