linux-kernel - Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALmu+SzCLNak9OT1KaB8hgEdWVQctQcwvC-9nQRN=Yekv++LmA@mail.gmail.com>
Date:	Sun, 8 Feb 2015 20:45:07 -0800
From:	Tolga Ceylan <tolga.ceylan@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sanjeev Sharma <sanjeev_sharma@...tor.com>,
	Mohammad Jamal <md.jamalmohiuddin@...il.com>,
	Loïc Pellegrino <oort10@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements

Thank you, I'll resubmit this with additional corrections to format strings.

On Sun, Feb 8, 2015 at 1:54 AM, Joe Perches <joe@...ches.com> wrote:
> On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote:
>> Lines over 80 were corrected
> []
>> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
> []
>> @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, HT_CHANNEL_WIDTH Bandwidth)
> []
>> +                     /* 8256 D-cut, E-cut, xiong: consider it later! */
>> +                     if (priv->card_8192_version == VERSION_819xU_A
>> +                             || priv->card_8192_version == VERSION_819xU_B) {
>
> This is more commonly written:
>
>                         if (priv->card_8192_version == VERSION_819xU_A ||
>                             priv->card_8192_version == VERSION_819xU_B) {
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/